Skip to content

Conversation

@sjanc
Copy link
Contributor

@sjanc sjanc commented Nov 8, 2021

This was affecting L2CAP/LE/CFC/BV-26-C and L2CAP/LE/CFC/BV-27-C
qualification test cases.

Signed-off-by: Szymon Janc [email protected]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the case where conn->type == BT_CONN_TYPE_BR?

Wouldn't you need to forward the complete boolean to that, and add the same handling in bt_l2cap_br_recv?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I don't know (and I have no way of testing that)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not too familiar with the BR code either; @jhedberg do you know?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fix is intended to be backported to 2.7 for LE qualification, do we really need to discuss BR/EDR here? (which is likely unused anyway). Even if BR/EDR is to be fixed I think it should be separate PR anyway

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if BR/EDR is to be fixed I think it should be separate PR anyway

You are changing the behavior of BR/EDR as well in this PR as far as I can tell, so I disagree with this statement.

@jhedberg and @joerchan probably have better input than me on this, so if they both approve, that's fine with me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the code has been changed, so that this is just for dynamic channels. LGTM :)

This was affecting L2CAP/LE/CFC/BV-26-C, L2CAP/LE/CFC/BV-27-C,
L2CAP/ECFC/BV-33-C and L2CAP/ECFC/BV-34-C qualification test cases.

Signed-off-by: Szymon Janc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants