-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Bluetooth: Disconnect L2CAP channel if peer sent too much data #40176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
subsys/bluetooth/host/l2cap.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the case where conn->type == BT_CONN_TYPE_BR?
Wouldn't you need to forward the complete boolean to that, and add the same handling in bt_l2cap_br_recv?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I don't know (and I have no way of testing that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not too familiar with the BR code either; @jhedberg do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fix is intended to be backported to 2.7 for LE qualification, do we really need to discuss BR/EDR here? (which is likely unused anyway). Even if BR/EDR is to be fixed I think it should be separate PR anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the code has been changed, so that this is just for dynamic channels. LGTM :)
This was affecting L2CAP/LE/CFC/BV-26-C, L2CAP/LE/CFC/BV-27-C, L2CAP/ECFC/BV-33-C and L2CAP/ECFC/BV-34-C qualification test cases. Signed-off-by: Szymon Janc <[email protected]>
This was affecting L2CAP/LE/CFC/BV-26-C and L2CAP/LE/CFC/BV-27-C
qualification test cases.
Signed-off-by: Szymon Janc [email protected]